Skip to content

refactor(core): use Box<u8> for ModuleSource.code instead of a String #14487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2022

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented May 4, 2022

Towards #2552
Towards #14485

@bartlomieju bartlomieju requested a review from AaronO as a code owner May 4, 2022 18:29
@bartlomieju bartlomieju changed the title refactor(core): use Vec<u8> for ModuleSource instead of a String refactor(core): use Box<u8> for ModuleSource instead of a String May 4, 2022
@bartlomieju bartlomieju requested a review from lucacasonato May 4, 2022 18:44
@bartlomieju bartlomieju requested a review from lucacasonato May 4, 2022 19:09
@bartlomieju bartlomieju changed the title refactor(core): use Box<u8> for ModuleSource instead of a String refactor(core): use Box<u8> for ModuleSource.code instead of a String May 4, 2022
@bartlomieju bartlomieju merged commit 45a4d75 into denoland:main May 5, 2022
@bartlomieju bartlomieju deleted the use_bytes_in_core branch May 5, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants